Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ss to ss3 in doc; also change gender to sex in tutorial #198

Merged
merged 39 commits into from
Oct 25, 2023

Conversation

e-perl-NOAA
Copy link
Collaborator

Main changes were changing all instances of ss to ss3 in 12runningSS.tex (even title from 12runningSS to 12runningSS3) and changing in tutorial files.

Change gender to sex in model tutorial file.

Minor formatting changes in other files.

Copy link
Contributor

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @e-gugliotti-NOAA. The code formatting cleanup is helpful in addition to the substantive changes.

I also like the use of v.3.30 instead of SS3.30, but there are a few inconsistencies remaining

I'm now seeing

  • "v.3.30" 164 times [good]
  • "version 3.30" 74 times [good]
  • "v. 3.30" 22 times [remove space]
  • "SS3.30" 10 times [change to "v.3.30" or "version 3.30"?]

There are also a variety of remaining occurrences uses of 3.30 or 3.24 with no "v." or "version " in front, but I'm not sure it's necessary to change all of these.

15special.tex Outdated Show resolved Hide resolved
Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I see need to deprecate SS3.30, which is muscle memory for me, but I'll go with the majority view.

@iantaylor-NOAA
Copy link
Contributor

@Rick-Methot-NOAA, on further review, it looks like this PR is mostly just changing "SS" to "SS3" and a few instances of "3.24" to "v.3.24" or "3.30" to "v.3.30", not replacing "SS3.30" (which was already rare in the documentation ). So maybe no further change in the version numbers are needed.

@Rick-Methot-NOAA
Copy link
Collaborator

Ok, so could be OK. In my thinking, SS3.30 is version 30 of SS3. So I agree that the statement "version SS3.30" is not correct. But stating "v.3.30" does not seem quite correct either because that would be version 3.30 of SS, not of SS3.

@e-perl-NOAA
Copy link
Collaborator Author

All references to versions of stock synthesis should be one of 3 variations:
stock synthesis v.3.xx.xx
v.3.xx.xx
version(s) 3.xx.xx

@e-perl-NOAA e-perl-NOAA requested a review from shcaba October 18, 2023 13:35
@e-perl-NOAA
Copy link
Collaborator Author

@shcaba Can you review the additions on the latest commit in this PR that include info on your stock assessment continuum tool?

@e-perl-NOAA
Copy link
Collaborator Author

@Rick-Methot-NOAA can you review the latest commit including language about Jason's app?

Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better as below, but couldn't find it in codespaces.

Stock Assessment Continuum Tool*: Available through github at https://github.com/shcaba/SS-DL-tool, the Stock Assessment Continuum Tool (previously known as the Stock Synthesis Data-limited Tool) is a Shiny-based application that provides an interface to upload catch time-series, age composition, length composition, and abundance index data and define model options within the application, which then writes Stock Synthesis input files.

@e-perl-NOAA
Copy link
Collaborator Author

@Rick-Methot-NOAA can you provide a final review on this so that I can merge?

@e-perl-NOAA e-perl-NOAA merged commit 759093f into main Oct 25, 2023
@e-perl-NOAA e-perl-NOAA deleted the change-ss-to-ss3 branch December 20, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.30.22 release documentation Improvements or additions to documentation Manual User Guides
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants