Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cv to lognormal se correction #208

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Cv to lognormal se correction #208

merged 5 commits into from
Jan 2, 2024

Conversation

e-perl-NOAA
Copy link
Collaborator

See issue #207

@e-perl-NOAA
Copy link
Collaborator Author

Added a little more clarification about log vs. natural space.

@Rick-Methot-NOAA
Copy link
Collaborator

I edited in codespace. Did we collide?

Cole-Monnahan-NOAA
Cole-Monnahan-NOAA approved these changes Jan 2, 2024
View reviewed changes
Copy link

@Cole-Monnahan-NOAA Cole-Monnahan-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "typically have a" to "typically assumed to have a"

and maybe "in log space" to "in log space required for inputs" or something just to make it clear that SS3 wants the SE in log space

@e-perl-NOAA
Copy link
Collaborator Author

@Rick-Methot-NOAA I don't think we collided, did you push the changes you made?

@e-perl-NOAA e-perl-NOAA merged commit 53d42f7 into main Jan 2, 2024
4 checks passed
@e-perl-NOAA e-perl-NOAA deleted the cv-to-lognormal-se-correction branch January 17, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cole-Monnahan-NOAA Cole-Monnahan-NOAA Cole-Monnahan-NOAA approved these changes

@Rick-Methot-NOAA Rick-Methot-NOAA Rick-Methot-NOAA approved these changes

Assignees
No one assigned
Labels
Manual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e-perl-NOAA @Rick-Methot-NOAA @Cole-Monnahan-NOAA