Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework UI of use recovery kit flow #450

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

aince42
Copy link
Contributor

@aince42 aince42 commented Feb 20, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@aince42 aince42 added the enhancement New feature or request label Feb 20, 2025
@aince42 aince42 requested a review from jkoenig134 February 20, 2025 16:07
@jkoenig134 jkoenig134 marked this pull request as ready for review February 21, 2025 09:36
@jkoenig134 jkoenig134 merged commit a3afe9c into use-recovery-kit-flow Feb 21, 2025
4 checks passed
@jkoenig134 jkoenig134 deleted the rework-ui-of-use-recovery-kit-flow branch February 21, 2025 09:37
jkoenig134 added a commit that referenced this pull request Feb 24, 2025
* feat: add new function upsertRestoreFromIdentityRecoveryKitSetting

* refactor: remove unused accountId parameter

* chore: update translations

* feat: handle backup device onboarding flow

* feat: add restore profile option to onboarding account screen

* feat: add route for restoring from identity recovery kit

* chore: remove comments

* chore: use better naming for translation

* chore: early return

* refactor: outsource function to utils

* chore: remove unused function

* chore: create new route for scan-on-restore-identity

* chore: update runner

* chore: use better naming

* chore: remove feature flag

* chore: remove unnecessary import

* feat: add error handling

* chore: add more error cases

* chore update translations

* chore: update error message to prevent unintended error message

* fix: simplify error code passing

* refactor: simplify error dialog title and content methods

* Rework UI of use recovery kit flow (#450)

* chore: update ScannerEntry

* chore: update InformationContainer

* chore: update InstructionsScreen

* chore: undo most scanner entry stuff

* fix: rm weird stuff

* feat: correct colors

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <[email protected]>

* chore: bump runtime

* refactor: make code readable and don't just randomly delete accounts

* fix: pop on cancel

* feat: allow to trigger the snackbar from everywhere

* fix: more tests

* fix: reload on widget change

* feat: show snackbars & pop

* chore: remove comment

* fix: warning icon for warnings

* chore: update ios stuff

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants