Bump cibuildwheel #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdpedigo
commented
Nov 18, 2024
| @@ -54,11 +54,11 @@ jobs: | |||
| - uses: actions/setup-python@v2 | |||
| name: Install Python | |||
| with: | |||
| python-version: '3.7' | |||
| python-version: '3.8' | |||
There was a problem hiding this comment.
3.8+ required by cibuildwheel https://github.com/pypa/cibuildwheel/blob/aac31ae2fb6f1bd1224a90f60f2e65cd419a54a3/pyproject.toml#L11
Closed
|
As expected there are some troubles 😅 I went through this with some other packages recently, let me try copying some build configs around. |
|
I folded this in with some other updates here #21 (and added you as a co-author to that PR, thanks!). That one seems to be working, just need to test the full build of the wheel matrix, which is running now on the main branch (the builds don't like to trigger on PRs for some reason... something wrong with the string check I guess.... something to debug another day). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps cibuildwheel to a more recent version, which includes python 3.12
Closes #19