chore: update dependencies #421
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (5)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe changes involve updates to the import paths and keeper declarations in the Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant Forwarding as Fwd
App->>Fwd: Import forwarding module
Fwd->>App: Forwarding functionalities available
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app.go (1)
Line range hint
56-95: Overall dependency update looks clean and focused.The changes are well-structured and maintain consistency:
- Import paths are updated to reflect the new module organization
- Changes are minimal and focused on dependency updates only
- No impact on application logic or behavior
Consider adding a changelog entry to document this dependency update for future reference.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (5)
e2e/go.modis excluded by!**/*.mode2e/go.sumis excluded by!**/*.sum,!**/*.sumgo.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum,!**/*.sumgo.work.sumis excluded by!**/*.sum,!**/*.sum
📒 Files selected for processing (2)
app.go(3 hunks)legacy.go(1 hunks)
🔇 Additional comments (5)
legacy.go (3)
Line range hint 120-135: Ensure middleware stack compatibility with updated forwarding module.
The forwarding middleware is a critical component in the IBC transfer stack. Since this PR updates the forwarding module, please ensure that:
- The middleware stack initialization remains compatible
- The interaction between forwarding middleware and other middleware components (PFM, blockibc) is not affected
#!/bin/bash
# Description: Check for any breaking changes in the forwarding middleware interface
# Test: Look for any changes in the middleware initialization pattern across the codebase
rg -A 2 "forwarding\.NewMiddleware\("Line range hint 15-43: Verify version constraints in go.mod.
Since this PR updates dependencies, please ensure that:
- The new forwarding module version is properly constrained in go.mod
- Integration tests pass to verify compatibility with other IBC modules
#!/bin/bash
# Description: Check version constraints and related modules
# Test 1: Check forwarding module version in go.mod
rg "github.com/noble-assets/forwarding/v2" go.mod
# Test 2: Check versions of related IBC modules
rg "github.com/cosmos/ibc-go/v8" go.mod42-42: Verify the forwarding module's new import structure.
The import path has been simplified from github.com/noble-assets/forwarding/v2/x/forwarding to github.com/noble-assets/forwarding/v2. While this aligns with the PR's dependency updates, we should verify the module's new structure.
✅ Verification successful
Let me gather more information about the forwarding module's structure and usage to ensure the import change is valid.
Import path change is valid and correctly implemented
The verification shows that:
- The new import path
github.com/noble-assets/forwarding/v2is correctly specified in go.mod as versionv2.0.0-rc.0 - The module is properly used in the codebase with consistent imports:
- Main module import in legacy.go
- Keeper import as
forwardingkeeperin app.go
- The ForwardingKeeper is correctly referenced in the middleware setup and app initialization
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the forwarding module's new structure and imports
# Test 1: Check if the new import path exists in go.mod
rg -l "github.com/noble-assets/forwarding/v2" go.mod
# Test 2: Verify that the forwarding types and keeper are still accessible
ast-grep --pattern 'forwarding.NewMiddleware($_, $_, $_)'
Length of output: 427
Script:
#!/bin/bash
# Check the actual usage of forwarding types and keeper in the codebase
rg "ForwardingKeeper" -A 2
# Check if there are any other imports from the forwarding module
rg "github.com/noble-assets/forwarding"
# Look for any potential breaking changes in the module initialization
ast-grep --pattern 'app.ForwardingKeeper = forwarding.$_'
Length of output: 1330
app.go (2)
95-95: LGTM! Keeper import path update is consistent.
The keeper import path change aligns with the module restructuring and maintains proper organization within the Noble modules section.
56-56: Verify forwarding module version compatibility.
The import path change suggests a significant restructuring in the forwarding module. Please ensure that:
- The version being imported is the intended release candidate
- All dependent modules are compatible with this version
✅ Verification successful
Import path update is consistent with the module version
The forwarding module is correctly set to v2.0.0-rc.0 in go.mod, and there are no remaining references to the old import path structure. The import path change aligns with the module's release candidate version.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the forwarding module version and its usage
# Check the go.mod file for the forwarding module version
rg -A 1 "github.com/noble-assets/forwarding/v2" go.mod
# Check for any remaining old import paths that might have been missed
rg "github.com/noble-assets/forwarding/v2/x/forwarding"
Length of output: 206
There was a problem hiding this comment.
Looks great @boojamya, thanks for getting on this!
I've resolved the merge conflicts on main, and additionally bumped CometBFT to the latest v0.38.x patch release. The Informal Systems released a new patch this morning EU time to resolve a bug in the vote extension logic (which for now is disabled on Noble).
Reason why I'm holding off on an approval is because the CometBFT patch included a Go version bump from v1.22 to v1.23, which I've reached out to their team in the #shared-community-cometbft Slack channel to explain further!
|
@Mergifyio backport v8.0.x-testnet |
✅ Backports have been created
|
Co-authored-by: John Letey <[email protected]> (cherry picked from commit d6e1153)
This PR: