Delete spinner in Introspection tools and fix endoding #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardvdK
commented
Feb 15, 2024
•
RichardvdK
commented
- don't spin inside the node, let the outside user determine how to spin this node and how to catch exceptions properly
- Fix encoding/ decoding of user_data messages. This most likely also fixes the "set as initial state" button in the smach_viewer
- updated test accordingly
- set_initial_state was called inside a callback, so rate.sleep() is replaced by time.sleep() (see rate docs)
…n this node and how to catch exceptions properly
RichardvdK
requested review from
Timple,
mbharatheesha,
MCFurry and
alireza-moayyedi
and removed request for
Timple,
mbharatheesha,
MCFurry and
alireza-moayyedi
RichardvdK
changed the title
|
I'm curious what the changes in the tests look like. |
added 3 commits
February 16, 2024 15:37
RichardvdK
changed the title
RichardvdK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.