Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

computeVelocityCommand has nested function with the same name. #120

Open
Timple opened this issue Mar 4, 2022 · 0 comments
Open

computeVelocityCommand has nested function with the same name. #120

Timple opened this issue Mar 4, 2022 · 0 comments
Labels
refactor Refactor request

Comments

@Timple
Copy link
Member

Timple commented Mar 4, 2022

This whole function only existed for the sake of the nav_core implementation.

Now that we don't have that legacy anymore. I think there are much better improvements to be made.

No we're calling computeVelocityCommands from the computeVelocityCommands function. It doesn't add any semantics. The 'main' computeVelocityCommands could be broken into functions with better descriptions.

Originally posted by @Timple in #115 (comment)
@Timple Timple changed the title `computeVelocityCommand has nested function with the same name. computeVelocityCommand has nested function with the same name. Mar 4, 2022
@Timple Timple mentioned this issue Mar 4, 2022
Merged
@lewie-donckers lewie-donckers added the refactor Refactor request label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactor request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Timple @lewie-donckers