Add missing Jazzy packages #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know, but they don't compile yet. |
Rayman
force-pushed
the
feature/add-missing-jazzy-packages
branch
from
3aee3f3 to
995575d
Compare
|
And only the off highway stuff? |
Timple
reviewed
Jun 24, 2024
| off_highway_sensor_drivers: | ||
| type: git | ||
| # Until: https://github.com/nobleo/off_highway_sensor_drivers | ||
| url: https://github.com/nobleo/off_highway_sensor_drivers.git |
There was a problem hiding this comment.
Why our fork? It doesn't contain improvements on the upstream.
There was a problem hiding this comment.
I just copied from iron.yaml. So you can ask that question to the person who put it there :)
|
So there is an issue with pcl_conversions. Also spatio_temporal_voxel_layer is affected by this. We can create a branch on our fork which fixes the dependencies in the meanwhile and build that one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also need these packages released for Jazzy