Skip to content

Commit

Permalink
feat: fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
jimbrig committed Sep 11, 2024
1 parent 90b46ef commit 8fd2ab5
Show file tree
Hide file tree
Showing 7 changed files with 36 additions and 11 deletions.
2 changes: 2 additions & 0 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ Depends:
R (>= 4.1)
Imports:
config (>= 0.3.2),
datasets,
glue,
golem (>= 0.4.1),
graphics,
rlang,
shiny (>= 1.8.1.1),
tibble
Expand Down
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ importFrom(golem,add_resource_path)
importFrom(golem,bundle_resources)
importFrom(golem,favicon)
importFrom(golem,with_golem_options)
importFrom(graphics,hist)
importFrom(rlang,.data)
importFrom(rlang,.env)
importFrom(shiny,HTML)
Expand Down
30 changes: 28 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,29 @@
# rshinycloudrun 0.0.1
# [Unreleased]

## Bug Fixes

- Fix GHA ([cb752bd](https://github.com/noclocks/demo-rshiny-cloudrun/commit/cb752bdc622288a73645ccf3b568b725eab2ff77)) - (Jimmy Briggs)
- Fix GHA ([0f67c58](https://github.com/noclocks/demo-rshiny-cloudrun/commit/0f67c5851d3ab40553bb27fc147884f30f890b69)) - (Jimmy Briggs)

## Configuration

- Tweak ignores ([b9c4ad7](https://github.com/noclocks/demo-rshiny-cloudrun/commit/b9c4ad7d1d6adfbcb2394cb761294151481b9273)) - (Jimmy Briggs)
- Buildignore index.md ([2de3533](https://github.com/noclocks/demo-rshiny-cloudrun/commit/2de35339adc8efc9a2d907accc330f51a774142f)) - (Jimmy Briggs)

## Documentation

- Separate index.md from README.md for pkgdown ([82ffd12](https://github.com/noclocks/demo-rshiny-cloudrun/commit/82ffd12e1811a09f33ea397411996e5aa9324535)) - (Jimmy Briggs)
- Add TOC ([cf26d28](https://github.com/noclocks/demo-rshiny-cloudrun/commit/cf26d2858b0187ddec814ca3cb7ae61885917471)) - (Jimmy Briggs)
- Add images ([4837232](https://github.com/noclocks/demo-rshiny-cloudrun/commit/4837232dc7d6ac483d6258812e6bdc818722dc69)) - (Jimmy Briggs)
- Update README ([1988447](https://github.com/noclocks/demo-rshiny-cloudrun/commit/1988447b504a5a7fd8dc4680e1fd877ce26426ba)) - (Jimmy Briggs)

## Features

- Bulk update ([f42c20a](https://github.com/noclocks/demo-rshiny-cloudrun/commit/f42c20aa230b015cee0bc50878f4077acea001af)) - (Jimmy Briggs)
- Update DESCRIPTION ([170a352](https://github.com/noclocks/demo-rshiny-cloudrun/commit/170a35213e20b4c5954b2fe94aea1729c741da33)) - (Jimmy Briggs)
- Add pkgdown ([311e384](https://github.com/noclocks/demo-rshiny-cloudrun/commit/311e38406b38d9cf36c0a4151f792c9ab7c8296d)) - (Jimmy Briggs)
- Add GHA for GHCR (docker-ghcr.yml) ([57fa3ed](https://github.com/noclocks/demo-rshiny-cloudrun/commit/57fa3ed317ca4b172c33022b427be3426e53e3c3)) - (Jimmy Briggs)
- Add terraform infra as code and docker build GHA ([eaacdfd](https://github.com/noclocks/demo-rshiny-cloudrun/commit/eaacdfdefd542306d4ec4af908130e88a0b251d0)) - (Jimmy Briggs)
- Add deployment and docker ([e4d9078](https://github.com/noclocks/demo-rshiny-cloudrun/commit/e4d907891b697b146f7dfe033bb008f85ca6d009)) - (Jimmy Briggs)


* Initial CRAN submission.
3 changes: 0 additions & 3 deletions R/app_config.R
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
#' matched `...`, or the empty string, `""`, if none matched.
#'
#' @seealso [system.file()]
#'
#' @examples
#' config_file <- app_sys("config/config.yml")
app_sys <- function(...) {
system.file(..., package = "rshinycloudrun")
}
Expand Down
6 changes: 4 additions & 2 deletions R/app_server.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
#'
#' @import shiny
#' @noRd
#' @importFrom datasets faithful
#' @importFrom graphics hist
app_server <- function(input, output, session) {
output$distPlot <- renderPlot({
# generate bins based on input$bins from ui.R
x <- faithful[, 2]
x <- datasets::faithful[, 2]
bins <- seq(min(x), max(x), length.out = input$bins + 1)

# draw the histogram with the specified number of bins
hist(x, breaks = bins, col = "darkgray", border = "white")
graphics::hist(x, breaks = bins, col = "darkgray", border = "white")
})
}
3 changes: 0 additions & 3 deletions man/app_sys.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/testthat/test-app_sys.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ test_that(
"app_sys works",
{
expect_true(
app_sys("config.yml") != ""
app_sys() != ""
)
}
)

0 comments on commit 8fd2ab5

Please sign in to comment.