Using BOs of type BO_SHMEM instead of BO_CMD for kernarg memory region (

#19) * Using BOs of type BO_SHMEM instead of BO_CMD for kernarg memory region * Changing test to use kernarg memory region for operand allocation
nod-ai · Sep 10, 2024 · 8a6677d · 8a6677d
1 parent ab60a07
commit 8a6677d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/rocrtst/suites/aie/aie_hsa_dispatch_test.cc b/rocrtst/suites/aie/aie_hsa_dispatch_test.cc
@@ -223,7 +223,7 @@ int main(int argc, char **argv) {
       num_data_elements * sizeof(std::uint32_t);
 
   std::uint32_t *input = {};
-  r = hsa_amd_memory_pool_allocate(global_dev_mem_pool, data_buffer_size, 0,
+  r = hsa_amd_memory_pool_allocate(global_kernarg_mem_pool, data_buffer_size, 0,
                                    reinterpret_cast<void **>(&input));
   assert(r == HSA_STATUS_SUCCESS);
   std::uint32_t input_handle = {};
@@ -232,7 +232,7 @@ int main(int argc, char **argv) {
   assert(input_handle != 0);
 
   std::uint32_t *output = {};
-  r = hsa_amd_memory_pool_allocate(global_dev_mem_pool, data_buffer_size, 0,
+  r = hsa_amd_memory_pool_allocate(global_kernarg_mem_pool, data_buffer_size, 0,
                                    reinterpret_cast<void **>(&output));
   assert(r == HSA_STATUS_SUCCESS);
   std::uint32_t output_handle = {};

diff --git a/runtime/hsa-runtime/core/driver/xdna/amd_xdna_driver.cpp b/runtime/hsa-runtime/core/driver/xdna/amd_xdna_driver.cpp
@@ -147,7 +147,7 @@ XdnaDriver::AllocateMemory(const core::MemoryRegion &mem_region,
   }
 
   if (region.kernarg()) {
-    create_bo_args.type = AMDXDNA_BO_CMD;
+    create_bo_args.type = AMDXDNA_BO_SHMEM;
   } else {
     create_bo_args.type = AMDXDNA_BO_DEV;
   }