[alt] remove default iree-compile extra args from onnx-iree mode #356
Conversation
|
@ScottTodd Should I revert the change to the cl config to use |
That's probably safer for now. Since the new flag hasn't been fully adopted in the IREE repo and doesn't have much mileage on it, it may be buggy. That's going to be easier to reason about upstream first, and that sort of flag change can also be made independently from the rest of the cleanup here. |
zjgarvey
force-pushed
the
iree-config-updates
branch
from
dd4269e to
ecab023
Compare
There was a problem hiding this comment.
LGTM, thanks! But let's wait for an approval from @ScottTodd too.
| self.extra_args = [ | ||
| "--iree-hip-target=gfx90a", | ||
| ] |
There was a problem hiding this comment.
FYI, we've been pulling this from an environment variable in other tests. See nod-ai/shark-ai#373 (comment) for some discussion
There was a problem hiding this comment.
Yeah, that's a good idea. It's a bit verbose to need to write out all the flags repeatedly.
Always using
iree-input-demote-i64-to-i32was causing numerics problems since it wasn't loading i64 inputs correctly. Additionally the flags for specifying the chip forhipis out of date, and should be removed. Users should specify-ica "iree-hip-target=gfx942" "other-arg" "other-arg" ...if compiling for Mi300.