Skip to content

Commit

Permalink
Fix setting Python3_EXECUTABLE (iree-org#18370)
Browse files Browse the repository at this point in the history
On Ubuntu `which python` quits with exit status 1 if the package
`python-is-python3` isn't installed, Only with this package installed,
`/usr/bin/python` does symlink to `python3`. See
https://packages.ubuntu.com/jammy/python-is-python3 and
https://packages.ubuntu.com/jammy/all/python-is-python3/filelist.
  • Loading branch information
marbre authored Aug 27, 2024
1 parent 271a14b commit 43ec1ef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci_linux_x64_clang_debug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
cmake \
-G Ninja \
-B ${BUILD_DIR} \
-DPython3_EXECUTABLE="$(which python)" \
-DPython3_EXECUTABLE="$(which python3)" \
-DCMAKE_BUILD_TYPE=Debug \
-DIREE_BUILD_PYTHON_BINDINGS=ON \
-DIREE_ENABLE_LLD=ON \
Expand Down
2 changes: 1 addition & 1 deletion docs/website/docs/building-from-source/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ Python executable to use with `Python3_EXECUTABLE`:
# Configure (including other options as discussed above)
cmake -G Ninja -B ../iree-build/ \
-DIREE_BUILD_PYTHON_BINDINGS=ON \
-DPython3_EXECUTABLE="$(which python)" \
-DPython3_EXECUTABLE="$(which python3)" \
.

# Build
Expand Down

0 comments on commit 43ec1ef

Please sign in to comment.