[NFC] Ability to add flags to peano's opt without recompiling iree #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newling
requested review from
makslevental,
nirvedhmeshram,
MaheshRavishankar,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
newling
force-pushed
the
peano_optimization_flag_optional
branch
from
189082c to
0f4201c
Compare
newling
changed the title
newling
changed the title
jtuyls
approved these changes
Dec 2, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/XCLBinGen.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Target/test/AMDAIEXCLBinGenTest.cpp
Show resolved
Hide resolved
…EXCLBinGenTest.cpp Co-authored-by: Jorn Tuyls <[email protected]>
Co-authored-by: Jorn Tuyls <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: we probably want -O3, but not completely commited yet (see #929)
I've added a c++ unit test, I've also tested this from run.py with
and it works, but I don't want this e2e style test to CI for now.
Also in PR:
-- use anonymous namespace for functions to in .h file
-- absorb #937 (will rebase this on that if that's reviewed first)