Skip to content

Commit

Permalink
make the logging comprehensible
Browse files Browse the repository at this point in the history
  • Loading branch information
archana-ramalingam committed Oct 30, 2024
1 parent ce68273 commit 56c8d3c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sharktank/sharktank/utils/export_artifacts.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def shard_irpa_file(

logger.info(f"Sharding irpa file:\n" f"cd {cwd} && {cmd}")

proc = subprocess.run(cmd, shell=True, capture_output=True, cwd=cwd)
proc = subprocess.run(cmd, shell=True, capture_output=True, cwd=cwd, text=True)
if proc.returncode != 0:
logger.error(
f"Error sharding irpa file with shard_llama.py\n"
Expand Down Expand Up @@ -125,7 +125,7 @@ def export_to_mlir(

logger.info(f"Exporting mlir:\n" f"cd {cwd} && {cmd}")

proc = subprocess.run(cmd, shell=True, capture_output=True, cwd=cwd)
proc = subprocess.run(cmd, shell=True, capture_output=True, cwd=cwd, text=True)
if proc.returncode != 0:
logger.error(
f"Error exporting mlir with export_paged_llm_v1.py\n"
Expand Down

0 comments on commit 56c8d3c

Please sign in to comment.