-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable building shortfin's Rust dependencies on Windows #620
Labels
infra
General category for infrastructure-related requests for common triaging and prioritization
Comments
marbre
added a commit
to marbre/shark-ai
that referenced
this issue
Nov 27, 2024
Sets up Rust to build shortfin with `SHORTFIN_ENABLE_TOKENIZERS` set to `ON` on Linux. At the moment, building with Rust is limited to Linux as there are build failures on Windows (see issue nod-ai#620).
marbre
added a commit
to marbre/shark-ai
that referenced
this issue
Dec 9, 2024
Sets up Rust to build shortfin with `SHORTFIN_ENABLE_TOKENIZERS` set to `ON` on Linux. At the moment, building with Rust is limited to Linux as there are build failures on Windows (see issue nod-ai#620).
marbre
added a commit
that referenced
this issue
Dec 9, 2024
Sets up Rust to build shortfin with `SHORTFIN_ENABLE_TOKENIZERS` set to `ON` on Linux. At the moment, building with Rust is limited to Linux as there are build failures on Windows (see issue #620).
4 tasks
IanNod
pushed a commit
to IanNod/SHARK-Platform
that referenced
this issue
Dec 17, 2024
Sets up Rust to build shortfin with `SHORTFIN_ENABLE_TOKENIZERS` set to `ON` on Linux. At the moment, building with Rust is limited to Linux as there are build failures on Windows (see issue nod-ai#620).
monorimet
pushed a commit
that referenced
this issue
Jan 8, 2025
Sets up Rust to build shortfin with `SHORTFIN_ENABLE_TOKENIZERS` set to `ON` on Linux. At the moment, building with Rust is limited to Linux as there are build failures on Windows (see issue #620).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
infra
General category for infrastructure-related requests for common triaging and prioritization
When using
ilammy/msvc-dev-cmd
to set up MSVC anddtolnay/rust-toolchain
to set up Rust, building withSHORTFIN_ENABLE_TOKENIZERS
set toON
fails on Windows with:This is not necessarily related to using the action
dtolnay/rust-toolchain
and is probably rather a problem withilammy/msvc-dev-cmd
+ Rust. GitHub rusted runners come withrustup
preinstalled but setting up a toolchain withrustup default stable
instead of usingdtolnay/rust-toolchain
results in similar build failures. If no MSVC is set up before,rustup-init
offers to take care and automatically install the prerequisites, see https://rust-lang.github.io/rustup/installation/windows-msvc.html, which is needs a closer look.The text was updated successfully, but these errors were encountered: