Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shortfin] Enable building Rust deps on Linux #619

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

marbre
Copy link
Collaborator

@marbre marbre commented Nov 27, 2024

Sets up Rust to build shortfin with SHORTFIN_ENABLE_TOKENIZERS set to
ON on Linux. At the moment, building with Rust is limited to Linux as
there are build failures on Windows (see issue #620).

@marbre marbre force-pushed the shortfin-ci-rust branch 2 times, most recently from 2f416b1 to d4ab539 Compare November 27, 2024 13:53
@marbre marbre changed the title Shortfin ci rust [shortfin] Enable building Rust deps on Linux Nov 27, 2024
@marbre marbre marked this pull request as ready for review November 27, 2024 14:00
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marbre
Copy link
Collaborator Author

marbre commented Nov 27, 2024

Some CMake warnings: https://github.com/nod-ai/shark-ai/actions/runs/12051730604/job/33603422869?pr=619#step:10:227

msgpack and sentencepiece (used in tokenizers-cpp) both set the CMake minimum to 3.1, which is something that probably would need to be adjusted upstream. There are some more warning which are worth a look but it seems to me that these are also issues that must be fixed upstream rather than downstream.

Sets up Rust to build shortfin with `SHORTFIN_ENABLE_TOKENIZERS` set to
`ON` on Linux. At the moment, building with Rust is limited to Linux as
there are build failures on Windows (see issue nod-ai#620).
@marbre marbre merged commit 5f7bfa9 into nod-ai:main Dec 9, 2024
16 checks passed
@marbre marbre deleted the shortfin-ci-rust branch December 9, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants