Split running ctest and pytest #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbre
force-pushed
the
libshortfin-split-ctest-pytest
branch
2 times, most recently
from
e2484f4
to
9841eab
Compare
ScottTodd
reviewed
Aug 26, 2024
Comment on lines
163
to
164
| # TOOD: Stop continuing on error after tests got fixed | ||
| continue-on-error: true |
There was a problem hiding this comment.
Another pattern for this is here: https://github.com/nod-ai/sharktank/blob/46b34c9df417c034ff64a598e7968ec420eb2175/.github/workflows/ci.yaml#L60-L68
That's also a bit buggy though - if the setup steps fail, the test steps will try to run.
You can be explicit and give jobs names, then allow running a step based on the conclusion of that step. See https://stackoverflow.com/a/75123818
There was a problem hiding this comment.
Thanks for the pointer, that was what I was looking for! For simplicity using !cancelled() for now and improve robustness in a follow up.
marbre
force-pushed
the
libshortfin-split-ctest-pytest
branch
from
9841eab
to
3247aec
Compare
ScottTodd
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.