Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sharktank] Rename CI config and set paths #334

Merged
merged 2 commits into from
Oct 26, 2024
Merged

[sharktank] Rename CI config and set paths #334

merged 2 commits into from
Oct 26, 2024

Conversation

marbre
Copy link
Collaborator

@marbre marbre commented Oct 25, 2024

No description provided.

@marbre marbre requested a review from ScottTodd October 25, 2024 20:17
@marbre marbre enabled auto-merge (squash) October 26, 2024 01:13
@marbre marbre merged commit ffb146b into nod-ai:main Oct 26, 2024
3 checks passed
@marbre marbre deleted the sharktank-ci branch October 28, 2024 14:39
@ScottTodd
Copy link
Member

FYI this was reverted as part of #343

I should have taken a closer look at this before approving. This change was not safe to make with the sharktank workflow, as mentioned at #298

Note that using paths filters on pull_request triggers breaks "required checks". We currently only set pre-commit and Unit Tests and Type Checking (3.11, ubuntu-latest) as required checks though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marbre @ScottTodd