[sharktank] Modernize setup.py based project
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
reviewed
Oct 30, 2024
sharktank/pyproject.toml
Outdated
Comment on lines
39
to
40
| [tool.setuptools.dynamic] | ||
| # version = {file = ["version_info"]} | ||
| dependencies = {file = ["requirements.txt"]} |
There was a problem hiding this comment.
Why is version commented out here? Could use a comment pointing to setup.py maybe?
ScottTodd
approved these changes
Oct 30, 2024
Moves over the project metadata and most parts of the build configuration to the `pyproject.toml`, see [1, 2]. The `setup.py` is kept to allow handling `version_info.json` files in a similar manner across all our project. [1] https://packaging.python.org/en/latest/guides/writing-pyproject-toml/ [2] https://packaging.python.org/en/latest/guides/modernize-setup-py-project/
marbre
force-pushed
the
sharktank-pyproject
branch
from
a45ea10 to
908b6e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #294
Moves over the project metadata and most parts of the build configuration to the
pyproject.toml, see [1, 2]. Thesetup.pyis kept to allow handlingversion_info.jsonfiles in a similar manner across all our project.[1] https://packaging.python.org/en/latest/guides/writing-pyproject-toml/
[2] https://packaging.python.org/en/latest/guides/modernize-setup-py-project/