Pin OS to specific versions #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now `ubuntu-latest` points to 22.04 but this will change in January. Instead of pinning latest, a specific version is pinned with this.
|
|
ScottTodd
approved these changes
Dec 11, 2024
Unavoidable with how GitHub handles required checks. You can either merge through it then swap which check is required, or remove the current check first. Grouping workflows via a "summary" step like how we have iree (and now iree-turbine) workflows set up does let you provide a reasonably stable check name to set as required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, runner images are pinned to specific versions instead of referring to
latest. This allows to have a controlled upgrade path instead instead of just waiting for when a change in the reference affects the workflows.