Update lib/oauth_middleware.js #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,7 @@ function login(req, res, next, options) { | |||
| var blogtype = req.query[blogtypeField]; | |||
| var referer = getReferer(req, options); | |||
| if (!options.homeUrl) { | |||
| options.homeUrl = 'http://' + req.headers.host; | |||
| options.homeUrl = req.socket.headers.scheme + '://' + req.headers.host; | |||
There was a problem hiding this comment.
req.headers.scheme? 如果 schme 为空，是否默认 http 呢？
|
那就 options.homeUrl = (req.socket.headers.scheme || 'http') + '://' + req.headers.host;呗 这个会没有吗？ |
|
@Danielking ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
应用在使用https时有点问题，自己定义homeUrl虽然可以解决问题但不爽，:)