Mysql node update for holding query directly. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration to free up the msg.topic.
|
I think your coverage tool is not including files with no coverage at all. |
|
👍! I'm fighting side effects from overwriting the |
|
Justin, would you find value in trying to get this actually merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the mysql node to have a direct query input in the node configuration to free up the msg.topic.
I had a previous pull request out there that was discussed, but didn't pass the CLA because I had some commits without email address set.
This feature attempts to solve the lack of a direct input of SQL query into node instead of over-writing the topic.
Mutating the topic in the middle of a flow seemed very strange to me when using the mysql node.