Update package.json #270
Update package.json #270
Conversation
Enable tree shaking
|
@puzrin Can anyone please help with the approval here? |
|
Which bundler are you using? I've not heard about |
|
Side effects is used for tree shaking. Here is the
document
https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free
Regards,
Jagjit Kaur
…On Sat, Mar 25, 2023 at 2:39 PM Samuel Plumppu ***@***.***> wrote:
Which bundler are you using? I've not heard about sideeffects in
package.json before - and this option is not mentioned in the npm docs as
far as I can see 🙂
—
Reply to this email directly, view it on GitHub
<#270 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAT4G75Q42A5PXUNWDLVK5DW55QXZANCNFSM6AAAAAAVLJ4TWE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks! I don't use webpack anymore, but I guess this will be relevant for webpack users :) |
| @@ -2,6 +2,7 @@ | |||
| "name": "pako", | |||
| "description": "zlib port to javascript - fast, modularized, with browser support", | |||
| "version": "2.1.0", | |||
| "sideeffects": false, | |||
There was a problem hiding this comment.
According to the docs you linked, the property should be sideEffects- note the casing difference.
Suggested change:
| "sideeffects": false, | |
| "sideEffects": false, |
There was a problem hiding this comment.
I have done the change. @Greenheart Could you please approve?
JagjitKaur#1
There was a problem hiding this comment.
Could you push the change to the same branch as this PR is based on (JagjitKaur:Pako/tree-shaking)?
I'm not a maintainer of this project, so I can't decide whether to merge or not.
However, this is consistent with the Webpack docs - hope it helps your project :)
Enable tree shaking for pako to reduce its package size in my app