Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OBS stream status and stream key update. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lamaral
Copy link

@lamaral lamaral commented Sep 17, 2018

Lange,

I extended the nodecg-utility-obs to obtain information if OBS is streaming and added the option to change the stream key from NodeCG.

I hope the code is useful. If it's not up to the standards, feel free to either direct me on how to enhance or fix as you would like.

@lamaral
Copy link
Author

lamaral commented Sep 17, 2018

I realized the documentation is missing. I'll take care of it tomorrow.

@lamaral lamaral force-pushed the master branch 2 times, most recently from 8af50a4 to 859b7b2 Compare September 17, 2018 12:06
@lamaral
Copy link
Author

lamaral commented Sep 17, 2018

859b7b2 contains the requested changes and updated documentation.

Please double check if I changed all space indentation to tabs.

@lamaral
Copy link
Author

lamaral commented Sep 25, 2018

I've struggled quite a lot trying to get it right, but the lint is asking for a change that breaks the obs-websocket-js library.

The lint complained I should use the shorter settings.key but if I do, the library complains that settings wasn't defined.

If you wanna close this PR, I don't mind.

@Hoishin
Copy link
Member

Hoishin commented Sep 25, 2018

what exactly is the eslint error?

@lamaral
Copy link
Author

lamaral commented Sep 26, 2018

<path>/nodecg-obs/packages/nodecg-utility-obs/index.js
  162:29  error  Unnecessarily quoted property 'settings' found  quote-props
  162:42  error  Unnecessarily quoted property 'key' found       quote-props
  162:42  error  Expected property shorthand                     object-shorthand

@Hoishin
Copy link
Member

Hoishin commented Sep 26, 2018

Run

npm run pretest -- --fix

And see if the same error happens after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants