-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: add some AdonisJS dependencies #1049
base: main
Are you sure you want to change the base?
Conversation
if the above pass, we can land this PR. If not, you should fix the relative failures and/or limit the platforms that you are targeting. |
I have updated the lookup file to remove platforms we don't plan to work on. It also seems that |
I think you can skip osx11-x64. I'm not sure about debian12-x64. There might be some race condition in those tests. |
Could you please re-run the |
@RomainLanz There are a bunch of errors. |
I known. I haven't got time to see why we have tests timing out in some environments. Also, I am not sure why the latest run didn't take the latest release that remove the "debug" mode. |
Here's a quick run on github actions with the latest release: https://github.com/nodejs/citgm/actions/runs/9004501814 |
@RomainLanz You can run it locally with |
Hey there! 👋🏻
This PR adds some packages required by the AdonisJS Framework to the Gold Mine to ensure that any new Node.js version does not break our code or that we can provide a fix beforehand.
Checklist
Hard Requirements
npm install && npm test
or (yarn install && yarn test
orpnpm install && pnpm test
) using the tarball downloaded from the Github tag mentioned aboveSoft Requirements
At least one of:
--