Use auto-updating Node.js test matrix via pkgjs/action #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matrix will be constructed automatically to include all supported versions, starting with the earliest one defined in the `engines` filed in `package.json`. Note that this will also include Node@17 for the time being, because technically it's still supported - it will drop off the matrix once support ends.
|
Should we use the defaults (14, 16, 17, 18) and let 17 fall off when it goes EOL on June 1? |
No objections. I only removed 17 from the matrix early to avoid having to do another PR when it goes EOL. |
BethGriggs
approved these changes
May 10, 2022
richardlau
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #891. Not closing it just yet, because I'm pondering if I should add a feature into
pkgjs/actionto enable the same approach for thetest-moduleworkflow... Not sure just yet. It is possible to use just the matrix generator from there, but it requires a bunch of boilerplate.The matrix will be constructed automatically to include all supported versions, starting with the earliest one defined in the
enginesfiled inpackage.json.Note that this will also include Node@17 for the time being, because technically it's still supported - it will drop off the matrix once support ends.
Checklist
npm testpasses: https://github.com/dominykas/node-citgm/actions/runs/2295632089here