Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: ensure successful dynamic import returns the same result #46662

Merged
merged 13 commits into from
Jul 26, 2023
Merged

module: ensure successful dynamic import returns the same result #46662

merged 13 commits into from
Jul 26, 2023

Commits on Jul 21, 2023

  1. module: ensure successful import returns the same result

    @aduh95
    aduh95 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    0f1fe00 View commit details
    Browse the repository at this point in the history

  2. create ModuleResolveMap class

    @aduh95
    aduh95 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    3bf7e02 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code reviews

    @aduh95
    aduh95 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    9f36bf7 View commit details
    Browse the repository at this point in the history

  4. Make the resolve cache a resolve cache

    @aduh95
    aduh95 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    aabe393 View commit details
    Browse the repository at this point in the history

  5. revert changes in test/es-module/test-esm-initialization.mjs

    @aduh95
    aduh95 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    be69edd View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. fix missing object

    @aduh95
    aduh95 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    dd06864 View commit details
    Browse the repository at this point in the history

  2. add benchmark

    @aduh95
    aduh95 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    631d7c6 View commit details
    Browse the repository at this point in the history

  3. add data: URL to benchmark

    @aduh95
    aduh95 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    c279d18 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. DRY

    @aduh95
    aduh95 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    56a8a07 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Geoffrey Booth <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
    @aduh95 @GeoffreyBooth @ljharb
    3 people authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    abf105a View commit details
    Browse the repository at this point in the history

  2. fix lint

    @aduh95
    aduh95 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    00ea14c View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Update lib/internal/modules/esm/module_map.js 

    Co-authored-by: Geoffrey Booth <[email protected]>
    @aduh95 @GeoffreyBooth
    aduh95 and GeoffreyBooth authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a791dc9 View commit details
    Browse the repository at this point in the history

  2. fix lint

    @aduh95
    aduh95 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3638858 View commit details
    Browse the repository at this point in the history