build: allow using alternate inspector_protocol path
#57116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
codebytere
added
the
embedding
codebytere
force-pushed
the
allow-inspector-protocol-path
branch
from
6dd605b to
e85451d
Compare
codebytere
force-pushed
the
allow-inspector-protocol-path
branch
from
e85451d to
12634f6
Compare
legendecas
approved these changes
Feb 18, 2025
zcbenz
reviewed
Feb 18, 2025
| @@ -193,7 +193,7 @@ template("node_gn_build") { | |||
| } | |||
| if (node_enable_inspector) { | |||
| deps += [ | |||
| "src/inspector:crdtp", | |||
| "$node_inspector_protocol_path:crdtp", | |||
There was a problem hiding this comment.
The crdtp target in inspector_protocol can not be built with Node.js (it has dependency on Chromium's things).
The ideal fix would be removing the dependency on Chromium in the upstream inspector_protocol, pulling it in Node, and then updating here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for embedder customization along the lines of similar dependency variables.
Electron needs this in order to prevent conflicts between different implementations in Node.js and Chromium.