Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update amaro to 0.4.0 #57121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of amaro to 0.4.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. strip-types Issues or PRs related to strip-types support labels Feb 18, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 18, 2025
@marco-ippolito
Copy link
Member

@nodejs/typescript PTAL

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (ba8fbf3) to head (07b49bb).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #57121   +/-   ##
=======================================
  Coverage   90.37%   90.38%           
=======================================
  Files         629      629           
  Lines      184373   184373           
  Branches    36022    36028    +6     
=======================================
+ Hits       166624   166639   +15     
+ Misses      10906    10905    -1     
+ Partials     6843     6829   -14     

see 27 files with indirect coverage changes

@marco-ippolito
Copy link
Member

marco-ippolito commented Feb 18, 2025

@kdy1 swc is not assigning the error.code property correctly to this error only in transform mode

nodejs/amaro#177

+ 'node:internal/assert:17\n' +
+   '  throw new ERR_INTERNAL_ASSERTION(message);\n' +
+   '  ^\n' +
+   '\n' +
+   'Error [ERR_INTERNAL_ASSERTION]:   x `module` keyword is not supported. Use `namespace` instead.\n' +
+   '   ,-[1:1]\n' +
+   ' 1 | module Greeter {\n' +
+   '   : ^^^^^^\n' +
+   ' 2 |     export interface Person {\n' +
+   ' 3 |         name: string;\n' +
+   ' 4 |     }\n' +
+   '   `----\n' +
+   '\n' +
+   'This is caused by either a bug in Node.js or incorrect usage of Node.js internals.\n' +
+   'Please open an issue with this stack trace at [https://github.com/nodejs/node/issues\n](https://github.com/nodejs/node/issues/n)' +
+   '\n' +
+   '    at Function.fail (node:internal/assert:17:9)\n' +
+   '    at parseTypeScript (node:internal/modules/typescript:72:49)\n' +
+   '    at processTypeScriptCode (node:internal/modules/typescript:129:42)\n' +
+   '    at stripTypeScriptModuleTypes (node:internal/modules/typescript:196:22)\n' +
+   '    at Module._compile (node:internal/modules/cjs/loader:1686:15)\n' +
+   '    at Object.loadTS [as .ts] (node:internal/modules/cjs/loader:1826:10)\n' +
+   '    at Module.load (node:internal/modules/cjs/loader:1469:32)\n' +
+   '    at Function._load (node:internal/modules/cjs/loader:1286:12)\n' +
+   '    at TracingChannel.traceSync (node:diagnostics_channel:322:14)\n' +
+   '    at wrapModuleLoad (node:internal/modules/cjs/loader:235:24) {\n' +
+   "  code: 'ERR_INTERNAL_ASSERTION'\n" +
+   '}\n' +
+   '\n' +
+   'Node.js v24.0.0-pre\n'

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-amaro branch from 569fc31 to 07b49bb Compare February 23, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants