src: fix ThrowInvalidURL call in PathToFileURL #57141
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `nullptr` with `std::nullopt` when calling `ThrowInvalidURL` in `PathToFileURL`. This ensures the function receives the correct argument type and aligns with the expected behavior.
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Feb 19, 2025
geeksilva97
approved these changes
Feb 19, 2025
github-actions
bot
removed
the
request-ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57141 +/- ##
==========================================
+ Coverage 88.54% 89.03% +0.49%
==========================================
Files 665 665
Lines 193408 193408
Branches 36961 37278 +317
==========================================
+ Hits 171250 172205 +955
+ Misses 14795 13884 -911
+ Partials 7363 7319 -44
|
|
Do we have a test with a malformed URL? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57133.
Replaces
nullptrwithstd::nulloptwhen callingThrowInvalidURLinPathToFileURL. This ensures the function receives the correct argument type and aligns with the expected behavior.PS: I'm not sure how to test this, any help would be appreciated.