Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: run Linux tests on GitHub arm64 runners as well #57162

Merged
merged 1 commit into from
Feb 23, 2025
+5 −1
Merged

tools: run Linux tests on GitHub arm64 runners as well #57162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/test-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ permissions:
jobs:
test-linux:
if: github.event.pull_request.draft == false
runs-on: ubuntu-24.04
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-24.04, ubuntu-24.04-arm]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we could go back to ubuntu-latest now that it's an alias for ubuntu-24.04 IIUC

Suggested change
os: [ubuntu-24.04, ubuntu-24.04-arm]
os: [ubuntu-latest, ubuntu-24.04-arm]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's better to be explicit and choose when we want to switch to 26.04. We had issues with automated updates in the past (new compiler may not work with the main branch).

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
Expand Down
Loading