http: support HTTP[S]_PROXY environment variables #57165
Draft
+1,338
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
joyeecheung
changed the title
joyeecheung
changed the title
|
I believe this will be a notable change. |
legendecas
added
the
notable-change
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
mcollina
reviewed
Feb 21, 2025
| @@ -26,6 +26,10 @@ module.exports.createFastMessageEvent = createFastMessageEvent | |||
|
|
|||
| module.exports.EventSource = require('./lib/web/eventsource/eventsource').EventSource | |||
|
|
|||
| const api = require('./lib/api') | |||
| const Dispatcher = require('./lib/dispatcher/dispatcher') | |||
| Object.assign(Dispatcher.prototype, api) | |||
There was a problem hiding this comment.
I opened a separate PR in undici nodejs/undici#4064 , let's discuss it there.
7 tasks
mcollina
added
the
semver-major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a POC. Just trying to open a PR first to see what folks think about this approach - that is, to support
HTTP_PROXYetc. environment variables out of the box. The exposure of the lower-level dispatcher and EnvHttpProxyAgent would be a different feature, but I think for many users, having the environment variables supported out of the box is already enough or more important to solve their headaches, while the lower-level utilities are less essential - many other language runtimes/command line tools only support these environment variables out of the box, without necessarily providing more utilities for further customization, and that seems enough for most people who are behind a proxy already.The idea is that we can first make this handling opt-in via another environment variable (
NODE_USE_ENV_PROXYhere, or we can use others if there are better names). And in the future we can enable this flag by default, as this is still opt-in under well-known environment variablesHTTP_PROXY. I think some investigation is needed to make sure that enabling it by default would not step on the toes of other libraries/tools already recognizing these environment variables and do their own thing.This requires a patch in undici to make the EnvHttpProxyAgent usable from the Node.js bundle, which I included locally in this PR and a locally built bundle for demonstration purpose. I opened a separate PR to undici to see what's the best way to patch it nodejs/undici#4064
I've only tested it with fetch so far, and left a TODO for handling of http global agents.
Refs: nodejs/undici#1650