-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: announce the new discord server #7490
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
NOTE -- PLEASE DO NOT MERGE THE PR; Ill manually merge it once it is ready 🙏 |
apps/site/pages/en/blog/announcements/official-discord-launch-announcement.md
Outdated
Show resolved
Hide resolved
Can we ask foundation to have a custom turtle rocket for discord. Like they do for Paris. And what about removing slack icon on footer and add discord one ? |
These are all irrelevant/unrelated to this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think prettier needs to be run here. Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT ! just private link
One other thought beyond the /discord redirect, should this be added to the site footer along with the other socials? |
Co-authored-by: Carl Vitullo <[email protected]> Signed-off-by: Claudio W <[email protected]>
…announcement.md Co-authored-by: Matt Cowley <[email protected]> Signed-off-by: Claudio W <[email protected]>
855d755
to
3eb4d1b
Compare
Good point! |
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
FYI updated the PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
The link to the private repository is still there. I suppose you want to keep it, but I'm not sure if it makes sense for the public, as it would result in a 404 if they try to access it. |
What link? |
apps/site/pages/en/blog/announcements/official-discord-launch-announcement.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Cowley <[email protected]> Signed-off-by: Claudio W. <[email protected]>
This PR announces the new official Discord community within the Node.js project. By including a blog post, updating the about page and adding a banner.