Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: announce the new discord server #7490

Merged
merged 10 commits into from
Mar 17, 2025
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Feb 11, 2025

This PR announces the new official Discord community within the Node.js project. By including a blog post, updating the about page and adding a banner.

@ovflowd ovflowd requested review from a team as code owners February 11, 2025 22:12
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 17, 2025 3:43pm

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 89 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
88.75% (742/836) 76.1% (242/318) 87.65% (142/162)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.329s ⏱️

@ovflowd
Copy link
Member Author

ovflowd commented Feb 11, 2025

NOTE -- PLEASE DO NOT MERGE THE PR; Ill manually merge it once it is ready 🙏

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Feb 12, 2025

Can we ask foundation to have a custom turtle rocket for discord. Like they do for Paris.
Also Claudio you can take a look at the bluesky automatization to make a post about this blog post

And what about removing slack icon on footer and add discord one ?

@ovflowd
Copy link
Member Author

ovflowd commented Feb 12, 2025

Can we ask foundation to have a custom turtle rocket for discord. Like they do for Paris. Also Claudio you can take a look at the bluesky automatization to make a post about this blog post

And what about removing slack icon on footer and add discord one ?

These are all irrelevant/unrelated to this PR...

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think prettier needs to be run here. Otherwise LGTM

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! just private link

@MattIPv4
Copy link
Member

One other thought beyond the /discord redirect, should this be added to the site footer along with the other socials?

@ovflowd ovflowd force-pushed the feat/announce-the-discord-server branch from 855d755 to 3eb4d1b Compare March 16, 2025 20:33
@ovflowd
Copy link
Member Author

ovflowd commented Mar 16, 2025

One other thought beyond the /discord redirect, should this be added to the site footer along with the other socials?

Good point!

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 16, 2025
Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@ovflowd
Copy link
Member Author

ovflowd commented Mar 16, 2025

FYI updated the PR:

  • Rebased
  • Updated Blog Post and Banner dates
  • Added redirect link for /:locale/discord and /discord (nodejs.org/discord)
  • Added Discord Footer SVG Icon (and updated some of the other SVGs)
  • Purged translated get involved pages so they can be translated (benefits from memorized translation)

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@bjohansebas
Copy link
Member

The link to the private repository is still there. I suppose you want to keep it, but I'm not sure if it makes sense for the public, as it would result in a 404 if they try to access it.

@ovflowd
Copy link
Member Author

ovflowd commented Mar 16, 2025

The link to the private repository is still there. I suppose you want to keep it, but I'm not sure if it makes sense for the public, as it would result in a 404 if they try to access it.

What link?

Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Claudio W. <[email protected]>
@ovflowd ovflowd merged commit eb68e5d into main Mar 17, 2025
4 of 5 checks passed
@ovflowd ovflowd deleted the feat/announce-the-discord-server branch March 17, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants