This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Solutions Exploration #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setTimeoutPromise(50) | ||
| .then(() => controller.return()); | ||
| ``` | ||
| Since the `getController` API only works on promises returned from async function invocations, the invoker can have full control over who gets to abort the operation. |
There was a problem hiding this comment.
How do you differentiate between Promises created by async functions and ones created with the new Promise constructor? Do you have an internal flag or something?
There was a problem hiding this comment.
It would really be up to the implementer, but I imagine you can internally map promises created for async functions to their controllers. Other kinds of promises would simply have no mapping (and no controller).
|
Closing this issue because the repository is being archived: nodejs/admin#283 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a (draft for a) solutions exploration document (as requested) discussing useful capabilities that can be exposed in order to solve some of the "extra" use-cases.
@benjamingr please review and comment. You are welcome to edit and add stuff we've talked about as well - e.g. the "context API" you mentioned and perhaps some of the examples you wrote in our last session.
Thanks.