Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CII-Best-Practices for Nodejs: Silver level #955

Merged
merged 54 commits into from
Aug 21, 2023
Merged

CII-Best-Practices for Nodejs: Silver level #955

merged 54 commits into from
Aug 21, 2023

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Apr 16, 2023 •
edited
Loading

Related #953

This pull request contains a dump of the current questions and answers for the Node.js project in OpenSSF Best Practices for Silver Level. The purpose is to review the current answers, update and comment on them until we have a final version, and then update the OpenSSF Best Practices site.

This was referenced Apr 16, 2023
Open
Open
@UlisesGascon UlisesGascon marked this pull request as ready for review April 16, 2023 16:17
UlisesGascon
UlisesGascon commented Apr 16, 2023
View reviewed changes
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
@UlisesGascon UlisesGascon mentioned this pull request May 12, 2023
Open
UlisesGascon
UlisesGascon commented Jun 23, 2023
View reviewed changes
Copy link
Member Author

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/security I closed the previous discussions and I added new ones.

The new ones are the last step before we can merge it 🙌

tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
tools/ossf_best_practices/silver_criteria.md Outdated Show resolved Hide resolved
UlisesGascon and others added 15 commits June 29, 2023 08:25
@UlisesGascon
Update tools/ossf_best_practices/silver_criteria.md
c492e73
@UlisesGascon
feat: update responses
6d842e1 
ref: nodejs#955 (comment)
@UlisesGascon
feat: update responses
8ba7500 
Ref: nodejs#955 (comment)
@UlisesGascon
feat: update responses
a83a6e9 
Ref: nodejs#955 (comment)
@UlisesGascon
feat: update responses
582d364 
ref: nodejs#955 (comment)
@UlisesGascon
Update tools/ossf_best_practices/silver_criteria.md
20c4287
@UlisesGascon
feat: update responses
93bbe44 
Ref: nodejs#955 (comment)
@UlisesGascon
Merge remote-tracking branch 'origin/feat/best-practices-silver' into…
3224d2d 
… feat/best-practices-silver
@UlisesGascon
feat: update responses
f6dbb3f
@UlisesGascon
feat: update responses
8052053
@UlisesGascon
feat: update responses
c5b4741
@UlisesGascon
Update tools/ossf_best_practices/silver_criteria.md
af5da07
@UlisesGascon
Update tools/ossf_best_practices/silver_criteria.md
46c5812
@UlisesGascon
feat: update responses
98fcafb 
ref: nodejs#955 (comment)
@UlisesGascon
feat: update responses
9c683bd 
ref: nodejs#955 (comment)
@UlisesGascon
Copy link
Member Author

UlisesGascon commented Jul 31, 2023 •
edited
Loading

Ok, so we managed to close all the discussions! 🎉🎉

@nodejs/security: can you perform a final review and approve this version?

cc: @ljharb @richardlau @tniessen @ShogunPanda @BethGriggs

ljharb
ljharb approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the remaining threads

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Aug 5, 2023 •
edited
Loading

In the last team meeting (see) we agreed to ask for a final review from the @nodejs/tsc.

In the meantime I will start working on #956 and prepare the discussions

RafaelGSS
RafaelGSS approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @nodejs/tsc

@UlisesGascon
Copy link
Member Author

Thanks a lot for all the hard work! ❤️

As agreed in our last meeting, I will merge this PR.

I hope to see the Silver badge soon 🙌

@UlisesGascon UlisesGascon merged commit b93ef8e into nodejs:main Aug 21, 2023
@UlisesGascon UlisesGascon deleted the feat/best-practices-silver branch August 21, 2023 08:02
tniessen
tniessen reviewed Aug 21, 2023
View reviewed changes
tools/ossf_best_practices/silver_criteria.md
Comment on lines +92 to +94
The project repository front page and/or website MUST identify and hyperlink to any achievements, including this best practices badge, within 48 hours of public recognition that the achievement has been attained. (URL required)

**Met**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be missing the required URL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch @tniessen. We have an issue open for it: nodejs/nodejs.org#5432 (comment). I hope that we can integrate it in the website 🤞

patrickm68 added a commit to patrickm68/security-wg-process that referenced this pull request Sep 14, 2023
@patrickm68 @UlisesGascon @marco-ippolito
CII-Best-Practices for Nodejs: Silver level (#955)
9978cb3 
* feat: copied passing criterial Questions and Answers

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* feat: update responses

Ref: nodejs/security-wg#955 (comment)

* feat:  update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* Update tools/ossf_best_practices/silver_criteria.md

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

Ref: nodejs/security-wg#955 (comment)

* feat: update responses

Ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* Update tools/ossf_best_practices/silver_criteria.md

* feat: update responses

Ref: nodejs/security-wg#955 (comment)

* feat: update responses

* feat: update responses

* feat: update responses

* Update tools/ossf_best_practices/silver_criteria.md

* Update tools/ossf_best_practices/silver_criteria.md

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

---------

Co-authored-by: Ulises Gascón <[email protected]>
Co-authored-by: Marco Ippolito <[email protected]>
@tniessen tniessen mentioned this pull request Sep 21, 2023
Merged
mattstern31 added a commit to mattstern31/security-wg-process that referenced this pull request Nov 11, 2023
@mattstern31 @UlisesGascon @marco-ippolito
CII-Best-Practices for Nodejs: Silver level (#955)
8f2a22e 
* feat: copied passing criterial Questions and Answers

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Ulises Gascón <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* Update tools/ossf_best_practices/silver_criteria.md

Co-authored-by: Marco Ippolito <[email protected]>

* feat: update responses

Ref: nodejs/security-wg#955 (comment)

* feat:  update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* Update tools/ossf_best_practices/silver_criteria.md

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

Ref: nodejs/security-wg#955 (comment)

* feat: update responses

Ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* Update tools/ossf_best_practices/silver_criteria.md

* feat: update responses

Ref: nodejs/security-wg#955 (comment)

* feat: update responses

* feat: update responses

* feat: update responses

* Update tools/ossf_best_practices/silver_criteria.md

* Update tools/ossf_best_practices/silver_criteria.md

* feat: update responses

ref: nodejs/security-wg#955 (comment)

* feat: update responses

ref: nodejs/security-wg#955 (comment)

---------

Co-authored-by: Ulises Gascón <[email protected]>
Co-authored-by: Marco Ippolito <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Nov 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito left review comments

@ovflowd ovflowd ovflowd left review comments

@mhdawson mhdawson mhdawson left review comments

@BethGriggs BethGriggs BethGriggs left review comments

@richardlau richardlau richardlau left review comments

@tniessen tniessen tniessen left review comments

@ShogunPanda ShogunPanda ShogunPanda left review comments

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@anonrig anonrig anonrig approved these changes

@ljharb ljharb ljharb approved these changes

Assignees

@UlisesGascon UlisesGascon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.