Merge pull request #176 from zackschuster/master

fix node 18 breakage

.github/workflows/test.yml

@@ -0,0 +1,26 @@
+on: push
+
+jobs:
+  test:
+    name: test
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        node: [^12, ^14, ^16, ^18]
+        os: [ubuntu-latest, windows-latest, macos-latest]
+
+    steps:
+      - name: checkout
+        uses: actions/checkout@v2
+
+      - name: node
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node }}
+
+      - name: install
+        run: npm install
+
+      - name: test
+        run: npm test

lib/smtp-connection.js

@@ -326,7 +326,10 @@ class SMTPConnection extends EventEmitter {
      */
     _onClose(/* hadError */) {
         if (this._parser) {
-            this._parser.closed = true;
+            // node 18 makes this a getter-only property, handled internally 
+            if (this._parser.canSetClosedProp) {
+                this._parser.closed = true;
+            }
             this._socket.unpipe(this._parser);
             this._parser = false;
         }

lib/smtp-stream.js

@@ -31,11 +31,25 @@ class SMTPStream extends Writable {
         // unprocessed bytes from the last parsing iteration (used in data mode)
         this._lastBytes = false;
 
-        this.closed = false;
+        // node 18 makes this a getter-only property, handled internally 
+        if (this.canSetClosedProp) {
+            this.closed = false;
+        }
+
         // once the input stream ends, flush all output without expecting the newline
         this.on('finish', () => this._flushData());
     }
 
+    get canSetClosedProp() {
+        try {
+            const { closed } = this;
+            this.closed = closed;
+            return true;
+        } catch (err) {
+            return false;
+        }
+    }
+
     /**
      * Placeholder command handler. Override this with your own.
      */

test/smtp-connection-test.js

@@ -1284,7 +1284,8 @@ describe('SMTPServer', function () {
             });
 
             server.onData = function (stream, session, callback) {
-                stream.pipe(fs.createWriteStream('/dev/null'));
+                const nullDevice = process.platform === 'win32' ? '\\\\.\\NUL' : '/dev/null';
+                stream.pipe(fs.createWriteStream(nullDevice));
                 callback();
             };