Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HexDex Page #629

Merged
merged 5 commits into from
Aug 30, 2018
Merged

HexDex Page #629

merged 5 commits into from
Aug 30, 2018

Conversation

ogsilvaa
Copy link
Contributor

  • +Tag noscript para JS deshabilitado
  • ~Ajuste de alto y ancho de cada insignia
  • +Cantidad de Insignias por región

  • +tag noscript for JS disabled
  • ~adjust height and width for each badge
  • +Count of badges by region

antes/before
image

despues/before
image

#628

+ Tag noscript para JS deshabilitado
~ Ajuste de alto y ancho de cada insgnia
'------
+ tag noscript for JS disabled
~ adjust height and width for each badge
+ conteo de insignia y tag no script
~ variable de funcion each sin usar
~ ajuste de ancho de caja
-----
~ function variable *each* without to use
~ adjust width of box
hexdex.html Outdated Show resolved Hide resolved
hexdex.html Outdated Show resolved Hide resolved
- Eliminación de definición de estilo directo.
~ Modificación de estilo y nueva clase .badge
- Eliminación de console.log
--------------

- Elimination of direct style definition.
~ Modification of style and new class .badge
- Removal of console.log
@ogsilvaa
Copy link
Contributor Author

  • Las observaciones fueron realizadas

  • The issues are ready

hexdex.html Outdated Show resolved Hide resolved
@ogsilvaa
Copy link
Contributor Author

@riyadhalnur please review this PR again. Regards

@ogsilvaa ogsilvaa merged commit cf00e7d into nodeschool:source Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants