-
Notifications
You must be signed in to change notification settings - Fork 254
Added KO #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added KO #219
Conversation
Fix JSON file line break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but I suggested some subtle changes that might sound more native to Korean.
I really appreciate your work!
"Plural-Forms: nplurals=2; plural=(n != 1);\n" | ||
|
||
msgid "header.subtitle" | ||
msgstr "채팅에서 간단한 인사는 하지 마세요" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "채팅에서 간단한 인사는 하지 마세요" | |
msgstr "채팅에서 간단한 인사만 하지는 마세요" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestion. Considering your opinion, I think "채팅에서 간단한 인사만 하지 마세요" sounds more natural.
Co-authored-by: Woojun Ro <[email protected]>
hopefully this gets merged. I'm tired of replying to hello messages |
@@ -37,7 +37,7 @@ const typed2 = new Typed('#strike', { | |||
'在吗?', | |||
'you there?', | |||
'fraeslis', | |||
'여보세요', | |||
'안녕하세요', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what did you do??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both “여보세요” and “안녕하세요” translate to “Hello” in English. However, “여보세요” is only used when answering a phone call, and it’s not appropriate for messaging or chatting. Instead, it is changed to "안녕하세요,” which carries a broader sense of greeting.
Hello! I have translated this project into Korean.
I hope it will be translated into more languages.