Transform scheduled stop point IDs before importing into OTP #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
force-pushed
the
scheduled-stop-points
branch
2 times, most recently
from
9a6da76 to
8f6006a
Compare
leonardehrenfried
force-pushed
the
scheduled-stop-points
branch
from
8f6006a to
41d0b9f
Compare
leonardehrenfried
force-pushed
the
scheduled-stop-points
branch
from
c18e390 to
79ce924
Compare
leonardehrenfried
changed the title
|
This is now ready for review, @clezag . |
|
Props on making a PR containing XSTL look reasonable |
|
Ideally it would be the upstream source that does the transformation. Is there a chance that they can fix their data instead of us building pipelines to work around the problem? |
|
@rcavaliere are they aware of the issue? |
|
@clezag yes. Unfortunately work in progress... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the IDs of the NeTEx scheduled stop points and the SIRI StopPoint refs do not match even though the SSP's do contain the correct ID but in the untyped grab bag of
KeyValue"stuff".This PR then uses an XSTL stylesheet (I can't believe I'm writing this) to transform the IDs into the correct format, so that NeTEx and SIRI matches.
In order to actually use the scheduled stop points, I also included the SIRI feeds and a preview version of OTP which is currently under review: opentripplanner/OpenTripPlanner#6397
cc @rcavaliere