-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing limits header #119
base: master
Are you sure you want to change the base?
Conversation
During testing of nokiatech#118, I hit an error about numeric_limits not being part of std. This was on Ubuntu Linux with g++ 11.3.0.
same on ubuntu 22, clang 18, header 'limits' missing |
A similar build error occurred in a fedora39 & gcc-c++ environment. |
why there is no one merge the code? |
I think the research team has moved on. Sometime teams don't stay around to maintain code - they have other work, change task priority. Maybe that is the case here. I don't ever expect this to be merged. I just left this open so you can apply it yourself if you need it. |
Hmm ok It's an important enough library though. I still feel like we should crown a fork king in this thread. |
I don't think its worth maintaining a fork, because its not an important library. I don't think it is widely packaged, therefore not widely used. If you want HEIF support, try https://github.com/strukturag/libheif/ (disclaimer - I'm a contributor to that project). If you just need AVIF support, try https://github.com/AOMediaCodec/libavif (disclaimer - I've contributed to that too). |
During testing of #118, I hit an error about numeric_limits not being part of std.
This was on Ubuntu Linux with g++ 11.3.0.