Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl/ko #2298

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Intl/ko #2298

wants to merge 2 commits into from

Conversation

Heartade
Copy link
Contributor

@Heartade Heartade commented Dec 4, 2022

Add Korean translation for Pinafore. (Work in progress)

@nolanlawson
Copy link
Owner

Thanks for opening this PR! Just so you're aware, Pinafore currently only supports translations if you host your own copy of it. https://github.com/nolanlawson/pinafore/blob/master/docs/Internationalization.md

@Heartade
Copy link
Contributor Author

Heartade commented Dec 6, 2022

Thanks for opening this PR! Just so you're aware, Pinafore currently only supports translations if you host your own copy of it. https://github.com/nolanlawson/pinafore/blob/master/docs/Internationalization.md

I actually found it to work only when I manually edit bin/getIntl.js file in addition to providing LOCALE environment variable. Is this expected behavior, or should I file a bug?

Also, hosting multiple builds with different locales within the same host e.g. en-us.pinafore.social could be a way to support multiple locales while dynamic internationalization is yet to arrive.

@nolanlawson
Copy link
Owner

I actually found it to work only when I manually edit bin/getIntl.js file in addition to providing LOCALE environment variable. Is this expected behavior, or should I file a bug?

No, that sounds about right, that's how it's supposed to work. See: https://github.com/nolanlawson/pinafore/blob/master/docs/Internationalization.md

Also, hosting multiple builds with different locales within the same host e.g. en-us.pinafore.social could be a way to support multiple locales while dynamic internationalization is yet to arrive.

Yes, this is what I had in mind, but didn't get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants