Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artifact in CI build #8

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Add artifact in CI build #8

merged 1 commit into from
Feb 12, 2024

Conversation

leejuyuu
Copy link
Collaborator

Save artifact file for debugging or testing.

Save artifact file for debugging or testing.
@leejuyuu leejuyuu marked this pull request as draft February 12, 2024 19:39
@leejuyuu leejuyuu marked this pull request as ready for review February 12, 2024 19:54
@mmahmoudian
Copy link
Member

Out of curiosity, aren't the artifacts already committed to gh-pages branch? I'm not against this change, I'm just interested to know if some files are slipping from cracks.

@leejuyuu
Copy link
Collaborator Author

This is for viewing the build artifact of PRs. So we can check before merge and deploy. I believe the gh-page branch updates after deploy?

@mmahmoudian mmahmoudian merged commit 7a86e86 into nomacs:main Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants