Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move parser level to entry points #250

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Move parser level to entry points #250

merged 2 commits into from
Sep 9, 2024

Conversation

ladinesa
Copy link
Collaborator

@ladinesa ladinesa commented Sep 9, 2024

No description provided.

JosePizarro3
JosePizarro3 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@JosePizarro3 JosePizarro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Sep 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10771279321

Details

  • 8 of 9 (88.89%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 93.029%
Changes Missing Coverage Covered Lines Changed/Added Lines %
electronicparsers/cp2k/parser.py 1 2 50.0%
Totals Coverage Status
Change from base Build 10682059740: -0.001%
Covered Lines: 35739
Relevant Lines: 38417
💛 - Coveralls

@ladinesa ladinesa merged commit 8d4ba60 into develop Sep 9, 2024
4 checks passed
@ladinesa ladinesa deleted the parser-level branch September 9, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosePizarro3 JosePizarro3 JosePizarro3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ladinesa @coveralls @JosePizarro3