-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump depedencies #263
Bump depedencies #263
Conversation
Updated the |
can you perhaps also fix the error associated with the removal of metainfo.Environment |
But this is on the nomad-lab side. I don't mind removing it, as long as Markus and Theodore agree. |
no i mean if there is still some lingering usage of Environment in the parsers, I remember removing them a few months back. I thought this is the reason for the failure in the tests, but it seems not |
No, the reason for the failure is the magres parser. (Btw, we should check on which schema the standalone plugin depends.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Pull Request Test Coverage Report for Build 11839729046Details
💛 - Coveralls |
@ladinesa Should I also open an issue for deprecating
That would remove the |
i added this in todo, we can adapt my implementation in magres parser where i did not use search |
please, note Sathya is developing the parser in its own repo and asked to disconnect the parser in here |
we should discuss how to handle external developments, since imo we should have full control over parsers that we interface with nomad |
This is a separate discussion. This PR just updates some dependencies. Sathya just has to properly set up his |
No description provided.