This repository has been archived by the owner on May 28, 2022. It is now read-only.
refactor: isolate faulty channels and retry channel task on faults #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Changes:
Code Changes
Agent::run
no longer borrows&self
and instead takes an agent-specific<Agent>Channel
struct that defines all data types needed to run one home <> replica channelAgent::run_many
builds an<Agent>Channel
struct and hands this off to anAgent::run
task; if the run task errors out, it will log error and try to start it again instead of returning error to top levelAgent::run_all
TODO:
[ ] add unit tests to mock faulty RPC
[x] add exponential backoff for retries
[x] metric to track channel number of channel faults
Closes #161