fix: issues of post merge review of #106 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkasm
reviewed
Nov 25, 2024
mariobuikhuizen
changed the title
mariobuikhuizen
force-pushed
the
fix_stream_not_stopping
branch
from
460c48e to
de56df6
Compare
alkasm
reviewed
Dec 3, 2024
alkasm
reviewed
Dec 3, 2024
mariobuikhuizen
force-pushed
the
fix_stream_not_stopping
branch
from
d47106e to
c29fb5d
Compare
Also separate the thread-safe code in it's own class, this also provides a place for the mutable _last_time member that we can't have on the frozen dataclass.
mariobuikhuizen
force-pushed
the
fix_stream_not_stopping
branch
from
c29fb5d to
b53efaf
Compare
jackparmer
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.