Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor bugs #267

Merged
merged 6 commits into from
May 6, 2024
Merged

fix: minor bugs #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b78e54d
feat(tabs): update id value
imklau Apr 22, 2024
7c0d74e
fix(scroll-button): add a default aria label value
imklau Apr 22, 2024
b735910
fix: update ids to PL
imklau Apr 22, 2024
1cd1db2
fix: add missing key to each card
imklau Apr 22, 2024
dc6d7a7
Merge branch 'main' into fixes
imklau Apr 22, 2024
7f607ff
Merge branch 'main' into fixes
imklau Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/design-system/components/scrollButton/ScrollButton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@ ScrollButton.propTypes = {
/**
* It's used to provide a text description for assistive technologies, like screen readers.
*/
ariaLabel: string.isRequired,
ariaLabel: string,
className: string,
}

ScrollButton.defaultProps = {
className: null,
ariaLabel: "Przejdź do kolejnej sekcji",
}

export default ScrollButton
2 changes: 1 addition & 1 deletion packages/design-system/patterns/tabs/Tabs.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const Tabs = ({ data, id, transparentContent, className }) => {
active={index === activeIndex}
aria-selected={index === activeIndex}
aria-controls={`${convertToSlug(id)}-${convertToSlug(tab)}`}
id={convertToSlug(tab)}
id={`${convertToSlug(id)}-${convertToSlug(tab)}`}
onClick={() => setActiveIndex(index)}
borderBottom={transparentContent || activeIndex !== index}
transparentContent={transparentContent}
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/templates/Animal/Animal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const Animal = ({ data, otherAnimals }) => (
<Typography variant="h3">
Sprawdź, kto jeszcze czeka na miłość
</Typography>
<ScrollButton sectionId="other-animals" />
<ScrollButton sectionId="inne-do-adopcji" />
</Styled.ScrollContainer>
</Container>

Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/templates/Animal/components/OtherAnimals/OtherAnimals.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import * as Styled from "./OtherAnimals.styled"

const OtherAnimals = ({ data }) => (
<Styled.Wrapper>
<Container id="other-animals">
<Container id="inne-do-adopcji">
<Styled.ContentContainer>
<TextBanner
heading="Czekają na nowy dom"
Expand Down
25 changes: 11 additions & 14 deletions packages/frontend/app/templates/FoundationBackstage/components/TeamCardList/TeamCardList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,16 @@ import Typography from "design-system/components/typography"
import { teamData } from "./teamData"
import * as Styled from "./TeamCardList.styled"

const CardList = () => (
<Styled.TeamCardContainer>
{Object.entries(teamData).map(([category, { title, members }]) => (
<>
<Typography variant="h3">{title}</Typography>
<Styled.Wrapper key={category}>
{members.map((member) => (
<TeamCard key={member.name} member={member} />
))}
</Styled.Wrapper>
</>
))}
</Styled.TeamCardContainer>
)
const CardList = () =>
Object.entries(teamData).map(([category, { title, members }]) => (
<Styled.TeamCardContainer key={category}>
<Typography variant="h3">{title}</Typography>
<Styled.Wrapper>
{members.map((member) => (
<TeamCard key={member.name} member={member} />
))}
</Styled.Wrapper>
</Styled.TeamCardContainer>
))

export default CardList
Loading