-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tmux-weather plugin. #43
Comments
Hey @kierun I have a very similar solution without problem with the 'e' at the end
I hope it will help |
Thank you! I removed all my lines, added yours, and the "e" vanished. Sadly, it was replaced by "n"! Running tmux 3.1, in case that's an issue…
Now, that is a superb option! Thank you. |
@kierun I'm running tmux 3.1 on macos catalina 10.15.4. I don't have the issue. However I'm using a self-made weather plugin. Out of curiosity I switched to plugin by xamut and I immediately noticed some problems with the alignment. |
@nikita-y Yes, there is some weird alignment going on. When I maximise then minimise the window, I get a 1/2 character gap which is filled with black where the extra character was. Trying xamut's minus Nord does not show this problem. Just if it matters: this happens on both Ubuntu and Fedora. It really should not matter… |
Adding dedicated support for every plugin would mean that the bar will burst when there are more requests from other users. That's why this plugin only provides a minimal default content to prevent bloat. Of course I'm very aware that users should be able to customize the content to fit their needs, but unfortunately the current implementation of the plugin doesn't allow to simply modify single elements but only disable the default content at all. There are more open requests in this repository for other plugins and a way to design the content per user configurations, but I haven't got the time to refactor the plugin to allow this. I'd appreciate every PR and contribution to make this possible. So for the weather plugin the only way is to customize the plugin sources on your own or disable the default content at all like described in the documentations I've linked above. |
@arcticicestudio No worries whatsoever. Thank you for you work and explanations. Sadly, I am at the limits of my knowledge of tmux configuration so would not even know where to start to help even if I had the time. ☹ However, do let me know if you want anything tested in the future. All the best and thank you for a super theme! ☺ |
The problem seems like your terminal, font and/or libc disagreeing about the width of the Unicode codepoints you are using for the weather symbols. You could try rebuilding tmux with |
@nicm I use st and that should support uft8… Of course, it is a trivially simple terminal which means it might not work. I tried re-compiling tmux with
|
It is not about general support for UTF-8 it is about the widths of the characters, if tmux and the terminal have different ideas about the width of characters that you use then the status line will not be aligned properly. Either it will be too long and wrap onto the following line, or it will be too short and there will be stray output at the end (like in your case). Are you sure you restarted tmux entirely after rebuilding? What is the actual character that is causing a problem? |
Right, but I don't know what weather icons are, can you copy and paste one of them here? |
I see the same problem on OS X, libc doesn't know the width of this symbol so tmux assumes it is width 1. If you run for example
Do you see this in the log?
If I build with libutf8proc then tmux gets the correct width 2. What version of utf8proc do you have? I have 2.5.0. |
I think you will have trouble actually if st is also using wcwidth(), so you may need to use a different terminal. |
Sadly, I see nothing in the logs.
I have
St does use that. Using |
If you look for
If tmux is using width 2 (with or without utf8proc), and it works in gnome-terminal, then it sounds like an st problem and you would be best talking to them about it. |
Ah, it does look like a st problem then:
I shall open a bug (if I can figure out how) with them and link to this issue… |
Source
Supporting that plugin would be great.
The text was updated successfully, but these errors were encountered: