This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
YAML.safe_load and ruby's unicode_normalize method #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEPRECATION WARNING: ActiveSupport::Multibyte::Chars#normalize is deprecated and will be removed from Rails 6.1. Use #unicode_normalize(:nfkc) instead.
|
Without this patch, on Rails 6.0 this deprecation warning will appear whenever |
|
This repo hasn't had any activity in some years. It looks like I may be a committer -- I don't remember how that happened! But I'm not an 'owner' who can add other committers/owners. And I haven't looked at this code and don't think I currently use it. If @norman is around, I wonder if they would consider making other people committers/owners to maintain the gem? I am not sure if it currently really has any active maintainers. If we don't hear from @norman, those interested in working on it (perhaps those writing PR's) might consider a fork? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced in ruby 2.2: https://www.honeybadger.io/blog/ruby-unicode-normalization/ (2.3 just got EOL)
about the safe_load, if doesn't change anything as it's just data files, I just don't like "eval"s in my code :)
also this doesn't work in rails 6 at least because of the ActiveSupport normalize method that got renamed