Fix CI #914
Merged
Fix CI #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously windows-latest was disabled in the same way Upgrade executing=2.0.1 (due to yanked version of 2.0.0)
|
Approving to get CI/CD running again. We should switch to windows-2022 and also probably switch the caching structure to new form that uses setup-python cache argument (much easier). Should also upgrade some of the GH-actions to their newer versions. But we can do all those in a newer PR. |
ktbyers
approved these changes
Jun 8, 2024
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR follows #909, the problem seemed to be that we switched to
windows-2019instead ofwindows-latestand a few years ago the windows tests seem to have been disabled all together but started to fail again as we only compared againstwindows-latestwe can probably look at reactivating these in a later PR.Also upgraded executing as version 2.0.0 was yanked. I saw that this was failing in the Windows install log initially and this part was cached for all other jobs, that change would be unrelated to this but probably doesn't hurt either.